Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup test files #1003

Closed
wants to merge 1 commit into from
Closed

cleanup test files #1003

wants to merge 1 commit into from

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Aug 6, 2022

After #984.
Per #984 (comment).

@mkitti
Copy link
Member

mkitti commented Aug 6, 2022

I prefer these comments to stay.

@musm
Copy link
Member

musm commented Aug 8, 2022

I appreciate the effort. Although I don't have a problem with this, this just seems like churn without benefit.

@mkitti
Copy link
Member

mkitti commented Sep 18, 2022

Thank you again for this. Having the utility of having the comments there seems to still outweigh the aesthetics at the moment.

For these to go away, an more effective approach would be to refactor the test sets into smaller sets.

@mkitti mkitti closed this Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants